Merged
Conversation
This replaces most uses of newArray(size) with the following sequence: 1. new raw array, without filling entries with nil 2. population code, append values into the array 3. finish raw array, only populate remaining entries with nil This reduces the overhead for constructing these arrays by avoiding the pre-population with nil values for elements that will just be overwritten anyway.
This guarantees we do not accidentally start referencing any surrounding state and allocating a lambda object.
* Use more newRawArray where appropriate * Use newEmptyArray for more arrays intended to be empty * Provide "each" logic for global names * More efficient iteration of Java methods in JavaLang Class ext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.