Merged
Conversation
While doing this I realized we in almost all cases run this method twice. I pruned back to only call this once and this eliminated almost all the calls.
This one is confusing. We have some Ruby impl but time.rb depends on date.rb which is a stdlib loaded thing. So we need to load it after enough of JRuby it bootstrapped but we want this loaded ultimately the same time as the Java impl of Time. I just put it at the end of Ruby#init but this is probably not right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is confusing. We have some Ruby impl but time.rb depends
on date.rb which is a stdlib loaded thing. So we need to load it
after enough of JRuby it bootstrapped but we want this loaded
ultimately the same time as the Java impl of Time. I just
put it at the end of Ruby#init but this is probably not right?