Conversation
…style in JRuby and java
…e files; comparing Strings by equals not on == in Java
… help method discardTopValue()); Addition of some @OverRide
String.equals(). Moved checks out of if conditions to extra variable, if it used at least twice
…nstead of long method calls
upstream from jruby master
Member
|
As I indicated on IRC, this PR is way too big, having too many disparate parts to be merged. Please separate them into smaller parts (one PR per one idea), and skip the stylistic changes (spaces, Thanks. |
Member
Author
|
Thanks for your feedback, I am new in contributing to open source projects. I split them into these pull requests |
Member
|
Thanks. I'm going to close this one, then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished my first code review: