Skip to content

Pass Enumerable#uniq arguments properly#8436

Merged
headius merged 1 commit intojruby:masterfrom
headius:enumerable_fixes
Jan 15, 2025
Merged

Pass Enumerable#uniq arguments properly#8436
headius merged 1 commit intojruby:masterfrom
headius:enumerable_fixes

Conversation

@headius
Copy link
Member

@headius headius commented Nov 20, 2024

This change has been made other places, like Enumerable#map, but as reported in #8435, it was not done for at least Enumerable#uniq.

Fixes #8435

Other fixes may get added here before merge.

This change has been made other places, like Enumerable#map, but
as reported in jruby#8435, it was not done for at least Enumerable#uniq.

Fixes jruby#8435
@headius
Copy link
Member Author

headius commented Jan 15, 2025

I'm going to merge this fix for just uniq so we can look into the other cases reported in #8435 separately. This will at least fix the core part of that issue.

@headius headius marked this pull request as ready for review January 15, 2025 18:34
@headius headius merged commit 2f915ca into jruby:master Jan 15, 2025
@headius headius deleted the enumerable_fixes branch January 15, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The values passed to the block parameter differ between map and uniq.

1 participant