Use Java 9+ Process.pid() to get pid#8354
Merged
headius merged 2 commits intojruby:masterfrom Oct 29, 2024
Merged
Conversation
headius
force-pushed
the
java9_process_pid
branch
from
a1beef8 to
43e4a0c
Compare
This avoids using reflection to access Process internals on JDK versions 9 and higher, reducing our our requirements for opening core JDK classes. In JRuby 10, we will remove all the reflective logic since that release targets at least Java 17. This may help fix jruby#7515 by providing access to a real pid on Java 9+ regardless of reflection access.
headius
force-pushed
the
java9_process_pid
branch
from
43e4a0c to
578c233
Compare
The base pid() (from Java 9+) depends on toHandle() being overridden and raises an error if that has not happened. However that method returns instances of ProcessHandle, also added in 9, so there's no way we can implement it for 8. This patch just overrides pid() altogether so toHandle() is not called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids using reflection to access Process internals on JDK versions 9 and higher, reducing our our requirements for opening core JDK classes. In JRuby 10, we will remove all the reflective logic since that release targets at least Java 17.
This may help fix #7515 by providing access to a real pid on Java 9+ regardless of reflection access.