Properly fall back if can't setAccessible#8306
Merged
headius merged 1 commit intojruby:jruby-9.3from Jun 27, 2024
Merged
Conversation
Changes in e8dbe9c broke this fallback by silencing errors from the old setAccessible (as part of becoming more module-friendly). This patch checks if the setAccessible was successful and returns null for any fields that could not be made accessible. This in turn allows the USABLE fallback to properly reflect actual usability.
Member
Author
|
This PR was made against 9.3 (since it broke at 9.3.0.0) but may not see a release there for some time. Setting milestone to 9.4.8.0 because that's where most users will end up seeing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in e8dbe9c broke this fallback by silencing errors from the old setAccessible (as part of becoming more module-friendly). This patch checks if the setAccessible was successful and returns null for any fields that could not be made accessible. This in turn allows the USABLE fallback to properly reflect actual usability.