Conversation
checkToInteger - Same as TypeConverter but it replaces it integerAsInt - Works from knowing we have RubyInteger and bounds checks to make sure we really have an int integerAsLong - Works from knowing we have RubyInteger and bounds checks to make sure we really have a long Fallout from this is realizing we had two checkToInteger but whatever used the more generic form which allows to pass in converter is no longer used for anything but #to_int. This PR deprecated both versions. In refactoring to use these I noticed in two places we were not even checking to see if the value was safely an int/long. The integerAs* provides this and is more direct/narrow in what it provides than num2int or num2long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkToInteger - Same as TypeConverter but it replaces it integerAsInt - Works from knowing we have RubyInteger and bounds checks to
make sure we really have an int
integerAsLong - Works from knowing we have RubyInteger and bounds checks to
make sure we really have a long
Fallout from this is realizing we had two checkToInteger but whatever used the more generic form which allows to pass in converter is no longer used for anything but #to_int. This PR deprecated both versions.
In refactoring to use these I noticed in two places we were not even checking to see if the value was safely an int/long. The integerAs* provides this and is more direct/narrow in what it provides than num2int or num2long.