Return the value of the block for IO.popen#8292
Merged
enebo merged 2 commits intojruby:masterfrom Jun 22, 2024
Merged
Conversation
enebo
requested changes
Jun 20, 2024
Member
enebo
left a comment
enebo
left a comment
There was a problem hiding this comment.
You figured it out but it would be great to add the extra return just to alleviate my future reading of this.
Author
|
I'm not sure why some of the tests failed. Can you handle this part? |
Member
|
@mullermp sure thing. This does not seem related to either of your PRs and both of your PRs were green before merging (and this last change should not be the cause here). If it is I will fix it up. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8278
Returns the value of the block for IO.popen and remove the test tag.