Fix pattern JIT Hash match and SyntaxError#8284
Merged
headius merged 2 commits intojruby:masterfrom Jun 5, 2024
Merged
Conversation
The JIT tries to optimize "eqq" operations ("===" call) to avoid
storing the return value only to immediately load it and check for
truthiness. That works fine in case/when where the eqq is always
followed by exactly one truth test, but for patterns the result of
the eqq is used in other tests later in the code (I think for
delayed determination of error conditions).
This patch adds a flag to EQQInstr to indicate if this was an eqq
used for pattern matching, which has more complicated load/store
requirements than a simple when.
Fixes jruby#8283
Normal Ruby exceptions raised during JIT should be propagated rather than wrapped. Fixes an issue in pattern matching specs where a syntax error gets raised lazily, during JIT, and the wrapping in NotCompileableException breaks the expectation.
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
SyntaxErrorraised lazily by IR building can happen during JIT at threshold=0 and the wrapping of it in NotCompileableException broke an expectation in the ruby specs.