Set writer modification time to now by default#8281
Merged
headius merged 1 commit intojruby:masterfrom Jun 4, 2024
Merged
Conversation
headius
force-pushed
the
fix_gzipwriter_default_mtime
branch
from
821c254 to
fd4035e
Compare
This was referenced Jun 4, 2024
CRuby does this lazily on first write, when it sets up the headers, but that laziness is handled inside jzlib for us. Just set it and if it is updated by user it will be updated in the writer. Fixes jruby#7879, which led to tests being skipped in rack/rack#2182.
headius
force-pushed
the
fix_gzipwriter_default_mtime
branch
from
fd4035e to
51e2951
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRuby does this lazily on first write, when it sets up the headers, but that laziness is handled inside jzlib for us. Just set it and if it is updated by user it will be updated in the writer.
Fixes #7879, which led to tests being skipped in
rack/rack#2182.