Skip to content

Fix IO#each_line specs#8240

Merged
enebo merged 6 commits intojruby:9.5-devfrom
enebo:io_each_line
May 16, 2024
Merged

Fix IO#each_line specs#8240
enebo merged 6 commits intojruby:9.5-devfrom
enebo:io_each_line

Conversation

@enebo
Copy link
Member

@enebo enebo commented May 15, 2024

Fix IO#each_line specs

This will also fix a few other incidental methods which share the same code in IO.

@enebo enebo added this to the JRuby 10.0.0.0 milestone May 15, 2024
enebo added 3 commits May 16, 2024 10:26
StringIO and possibly other native extensions do not mark their
methods with `keywords=true`.  At some future point they should
do that and call the newer versions of `getlineCall`.

This commit emulates the old behavior in the deprecated methods which
will basically accept that a hash in last position is a kwarg.  This
is not 100% correct but it has not been correct for a long time.  So
this will not make the compatibility any worse but also will not require
a release of stringio in step with JRuby 10.
@enebo enebo merged commit 91f0d71 into jruby:9.5-dev May 16, 2024
@enebo enebo deleted the io_each_line branch March 4, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant