Skip to content

fix #823#824

Merged
headius merged 1 commit intojruby:masterfrom
sclasen:sclasen-fix-823
Jun 24, 2013
Merged

fix #823#824
headius merged 1 commit intojruby:masterfrom
sclasen:sclasen-fix-823

Conversation

@sclasen
Copy link
Contributor

@sclasen sclasen commented Jun 24, 2013

Applied the fix from jruby/jruby-ossl#7 built jruby and used the build to run my broken test, which passed.

@headius
Copy link
Member

headius commented Jun 24, 2013

The fix passed all tests except one, so I'll go ahead with a merge. Do you perhaps have a small test case we could incorporate into our suite for this?

headius added a commit that referenced this pull request Jun 24, 2013
@headius headius merged commit ccba557 into jruby:master Jun 24, 2013
@sclasen
Copy link
Contributor Author

sclasen commented Jun 24, 2013

Let me see if I can isolate something

On Mon, Jun 24, 2013 at 3:42 PM, Charles Oliver Nutter <
notifications@github.com> wrote:

The fix passed all tests except one, so I'll go ahead with a merge. Do you
perhaps have a small test case we could incorporate into our suite for this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/824#issuecomment-19941371
.

@sclasen
Copy link
Contributor Author

sclasen commented Jun 24, 2013

@headius I have a test case which will blow up on 1.7.4 and work on the PR.

It needs to load a file, (ca_certs.pem extracted from mozilla). Where would I put such a file in the jruby codebase?

Also I assume I would put the spec in spec/ruby/library/openssl/x509 ?

LMK, I'll submit another PR

@headius
Copy link
Member

headius commented Jun 24, 2013

@sclasen Yeah that would be good. I can coordinate getting it back into RubySpec upstream. Thank you!

@sclasen
Copy link
Contributor Author

sclasen commented Jun 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants