Conversation
|
The fix passed all tests except one, so I'll go ahead with a merge. Do you perhaps have a small test case we could incorporate into our suite for this? |
|
Let me see if I can isolate something On Mon, Jun 24, 2013 at 3:42 PM, Charles Oliver Nutter <
|
|
@headius I have a test case which will blow up on 1.7.4 and work on the PR. It needs to load a file, (ca_certs.pem extracted from mozilla). Where would I put such a file in the jruby codebase? Also I assume I would put the spec in spec/ruby/library/openssl/x509 ? LMK, I'll submit another PR |
|
@sclasen Yeah that would be good. I can coordinate getting it back into RubySpec upstream. Thank you! |
|
@headius testcase here https://github.com/sclasen/jrubyfix-823 |
Applied the fix from jruby/jruby-ossl#7 built jruby and used the build to run my broken test, which passed.