More string interpolation optimizations#8236
Merged
headius merged 1 commit intojruby:9.5-devfrom May 14, 2024
Merged
Conversation
* Don't re-copy the buffer when creating initial buffer from first static string. * Log how the dstring has been bound by indy * Additional cases in benchmark * Benchmark reuses proc to omit block creation overhead. * Stringable returns same frozen string to avoid new string cost.
headius
force-pushed
the
more_string_interpolation_optz
branch
from
9fa971b to
b4ec0e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The string interpolation optimizations in #8180 left some improvements on the table. This PR implements those missing bits.
I also added more logging of dstring forms in the indy site and some additional cases in the benchmark. It's now consistently much faster than the old logic.