Merged
Conversation
This reverts commit 4302ab9. This change needs to be examined more along with how we use frame name and binding name for different types of non-method scopes.
This reverts commit f7dbc18. These need to be examined in more detail because they do not match and I don't know why.
This reverts commit b7ce7d1. This needs to be examined because it ended up with a null frame name from somewhere and binding.getMethod does not match frame name for unknown reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly reverting places where I tried to null out or dig up the proper frame method name for non-method scopes, many of which have no frame method name. We need to re-example all frame name and binding name (which frequently doesn't match) logic to ensure we're passing an appropriate method name through for both backtraces and
__method__.