Merged
Conversation
In implementing the feature I took the least complicated route. We get a new Operand and in JIT we just add a second chilled boolean vs trying to shave this to a three-state value. One uncertainty is that I mark chilled as both frozen and chilled in RubyString flags. I did this because there are lots of isFrozen() checks in our codebase and I would like to fail fast if we find a path where chill should convert to mutable and we miss it. If we were certain we could probably only set chill flag and then check that in `frozen?`.
…rly mark mutable strings
…o not cache them like frozen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In implementing the feature I took the least complicated route. We get a new Operand and in JIT we just add a second chilled boolean vs trying to shave this to a three-state value.
One uncertainty is that I mark chilled as both frozen and chilled in RubyString flags. I did this because there are lots of isFrozen() checks in our codebase and I would like to fail fast if we find a path where chill should convert to mutable and we miss it. If we were certain we could probably only set chill flag and then check that in
frozen?.