fix slice_before on empty enumerable#822
Merged
BanzaiMan merged 1 commit intojruby:masterfrom Jun 24, 2013
statianzo:slice_before-fix
Merged
fix slice_before on empty enumerable#822BanzaiMan merged 1 commit intojruby:masterfrom statianzo:slice_before-fix
BanzaiMan merged 1 commit intojruby:masterfrom
statianzo:slice_before-fix
Conversation
This fixes an issue where calling slice_before on an empty enumerable would return an enumerable containing one element of nil
BanzaiMan
added a commit
that referenced
this pull request
Jun 24, 2013
fix slice_before on empty enumerable
Member
|
Thanks! The test should go to RubySpec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where calling slice_before on an empty enumerable
would return an enumerable containing one element of nil
Would you also like a test added to rubyspec around this?