Skip to content

Always unwrap old initialize methods#8211

Merged
headius merged 1 commit intojruby:masterfrom
headius:unwrap_delegated_constructors
Apr 25, 2024
Merged

Always unwrap old initialize methods#8211
headius merged 1 commit intojruby:masterfrom
headius:unwrap_delegated_constructors

Conversation

@headius
Copy link
Member

@headius headius commented Apr 25, 2024

If these are delegated or wrapped by profiling, we will fail type comparisons later on. Those comparisons are fragile, but for now this is the simplest fix.

Fixes #8148

@headius headius added this to the JRuby 9.4.7.0 milestone Apr 25, 2024
@headius headius changed the title Always unwrap old initialize methos Always unwrap old initialize methods Apr 25, 2024
If these are delegated or wrapped by profiling, we will fail type
comparisons later on. Those comparisons are fragile, but for now
this is the simplest fix.

Fixes jruby#8148
@headius headius force-pushed the unwrap_delegated_constructors branch from 0c3bf75 to 9643320 Compare April 25, 2024 18:17
@headius headius merged commit 7b29cb4 into jruby:master Apr 25, 2024
@headius headius deleted the unwrap_delegated_constructors branch April 25, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Profiler raises 'wrong number of arguments for constructor (ArgumentError)' for the march_hare gem

1 participant