opted case needs to use updated ints when loaded into new runtime.#8209
Merged
enebo merged 2 commits intojruby:masterfrom Apr 25, 2024
Merged
opted case needs to use updated ints when loaded into new runtime.#8209enebo merged 2 commits intojruby:masterfrom
enebo merged 2 commits intojruby:masterfrom
Conversation
headius
added a commit
to headius/jruby
that referenced
this pull request
Nov 14, 2024
When deserializing a BSwitch we recalculate the values for the switch based on the new runtime, which mostly means getting new Symbol IDs. This was fixed in jruby#8209. However we need to ensure that the jump table is sorted or the binary search for the switch will sometimes fail. This patch sorts the related tables based on the new switch values. Fixes jruby#8421
headius
added a commit
to headius/jruby
that referenced
this pull request
Nov 14, 2024
When deserializing a BSwitch we recalculate the values for the switch based on the new runtime, which mostly means getting new Symbol IDs. This was fixed in jruby#8209. However we need to ensure that the jump table is sorted or the binary search for the switch will sometimes fail. This patch sorts the related tables based on the new switch values. Fixes jruby#8421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8157. the int values we calculate are only valid for the runtime they are created in. When loading AOT code we have to generate new int values. This fix just saves the operands we are making the jump table for so we can regenerate new ints from them.