Skip to content

Only set up Java:: constants when accessed directly#8208

Merged
headius merged 2 commits intojruby:masterfrom
headius:more_lazy_java_constant_setup
Apr 25, 2024
Merged

Only set up Java:: constants when accessed directly#8208
headius merged 2 commits intojruby:masterfrom
headius:more_lazy_java_constant_setup

Conversation

@headius
Copy link
Member

@headius headius commented Apr 24, 2024

Previously whenever we see a new type of Java object, we both set up the proxy class AND set the constant. If that object's class is not from the typical Java integration classloader hierarchy, it will pollute the Java:: module with a normally inaccessible entry.

This change only sets up the constant when it is accessed through the normal package reference, rather than when first seen.

Fixes #8156.

Previously whenever we see a new type of Java object, we both set
up the proxy class AND set the constant. If that object's class
is not from the typical Java integration classloader hierarchy, it
will pollute the Java:: module with a normally inaccessible entry.

This change only sets up the constant when it is accessed through
the normal package reference, rather than when first seen.

Fixes jruby#8156
In order to avoid polluting the Java:: namespace with classes from
other classloader hierarchies, we are modifying the proxy class
setup process to not eagerly set a constant for newly-encountered
classes. This property controls the behavior, defaulting to true
for JRuby 9.4.x but likely to switch to false in a future release
(probably JRuby 10).

The constants will still be defined if accessed directly, as
before. We just won't define them when we happen to see an object
with an unfamiliar type.

See jruby#8208 and the bug it fixed jruby#8156.
@headius
Copy link
Member Author

headius commented Apr 25, 2024

This is now guarded by an option so we can ship it in 9.4.7.0.

@headius headius added this to the JRuby 9.4.7.0 milestone Apr 25, 2024
headius added a commit to headius/jruby that referenced this pull request Apr 25, 2024
@headius headius merged commit 8ceb1c7 into jruby:master Apr 25, 2024
@headius headius deleted the more_lazy_java_constant_setup branch April 25, 2024 19:36
headius added a commit to headius/jruby that referenced this pull request Apr 25, 2024
headius added a commit to headius/jruby that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JRuby adds Java proxy classes to the Java module even if they are not from JRubyClassLoader

1 participant