Partially undo kwarg optz from #8095#8207
Merged
headius merged 1 commit intojruby:masterfrom Apr 24, 2024
Merged
Conversation
In jruby#8095 (jruby/jruby@121c60fb) I optimized the JIT to statically compile in the logic for ruby2_keywords at the time of JIT. Unfortunately there turned out to be too many cases where this flag can change at runtime, leading to bugs like jruby#8119 where a previously-jitted scope gets flipped to ruby2_keywords later on. This patch partially reverts that optimization and resumes passing in the live ruby2_keywords value from the scope. We can revisit this in the future when it is possible to throw out and re-compile scopes that get this flag set later on. Fixes jruby#8119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8095 (121c60fb) I optimized the JIT to statically compile in the logic for ruby2_keywords at the time of JIT. Unfortunately there turned out to be too many cases where this flag can change at runtime, leading to bugs like #8119 where a previously-jitted scope gets flipped to ruby2_keywords later on.
This patch partially reverts that optimization and resumes passing in the live ruby2_keywords value from the scope. We can revisit this in the future when it is possible to throw out and re-compile scopes that get this flag set later on.
Fixes #8119