Skip to content

Fixes for regressions from recent optimizations#8190

Closed
headius wants to merge 1 commit intojruby:9.5-devfrom
headius:optz_regression_fixes
Closed

Fixes for regressions from recent optimizations#8190
headius wants to merge 1 commit intojruby:9.5-devfrom
headius:optz_regression_fixes

Conversation

@headius
Copy link
Member

@headius headius commented Apr 5, 2024

There are a few regressions that snuck in from recent optimization work (#8170 #8172 #8176 #8177 #8180). This PR will fix them.

@headius headius added this to the JRuby 10.0.0.0 milestone Apr 5, 2024
These names will leak out in stack traces so may need to be
reconsidered.
@headius headius force-pushed the optz_regression_fixes branch from 18e8a0f to 9121f72 Compare April 12, 2024 06:43
@headius
Copy link
Member Author

headius commented May 28, 2024

This is invalid now. I reverted some of the changes made and limited the __method__ and __callee__ optimization to method scopes, which avoids the problematic places where different frame name and stack name are being passed. That still needs to be investigated and fixed but this narrows the scope of the optimization to known good paths.

@headius
Copy link
Member Author

headius commented May 28, 2024

#8227

@headius headius deleted the optz_regression_fixes branch May 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant