[ji] support re-reifying class hierarchy#8185
Merged
enebo merged 7 commits intojruby:masterfrom Apr 29, 2024
Merged
Conversation
but starting with a simple name that is backwards compatible
kares
force-pushed
the
fix-java_sub_class_re-reify3
branch
from
c9b9c32 to
ec94c2d
Compare
headius
reviewed
Apr 23, 2024
Member
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
Looks good, only note is about us making package name configurable in preparation for modularity work in JRuby 10.
| } | ||
|
|
||
| private String getReifiedJavaClassName() { | ||
| final String basePackagePrefix = "rubyobj."; |
Member
There was a problem hiding this comment.
This might be a good time to select a new package name that can fit in with JPMS, or perhaps to provide a way for users to configure the package name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an attempt at fixing proper re-reification of Java (sub-)class hierarchy... (#8141)
this version behaves the same 99% of production uses (Java class name is kept); but when a Java class gets re-reified it will start using a versioned suffix (
@v1) for the Java class name.2 previous attempts: