Simplify fixnum and string ranges#8176
Merged
headius merged 1 commit intojruby:9.5-devfrom Mar 30, 2024
Merged
Conversation
Fixnum and String ranges can be reduced in complexity by doing all of the construction in one go rather than each piece individually. A Range of fixnum..fixnum now uses indy to pass the long values to the bootstrap, avoiding bytecode to construct the fixnum objects. A Range of string..string embeds the bytelist and CR into the bootstrap parameters, for the same result. Both also have simplified forms in the non-indy JIT mode. From ideas list in jruby#7588.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixnum and String ranges can be reduced in complexity by doing all of the construction in one go rather than each piece individually. A Range of fixnum..fixnum now uses indy to pass the long values to the bootstrap, avoiding bytecode to construct the fixnum objects. A Range of string..string embeds the bytelist and CR into the bootstrap parameters, for the same result. Both also have simplified forms in the non-indy JIT mode.
From ideas list in #7588.