Fix enum arg handling in Enumerator Nexter#815
Merged
1 commit merged intojruby:masterfrom Jun 21, 2013
Merged
Conversation
The Nexter for Enumerators needs to have its enum args packed in the same way as each_with_index. Refactor the arg handling in EachWithIndex to cover this case too.
Contributor
Author
|
Hrm... I see Travis didn't like this pull, but that must be a red herring: I got a clean run on my branch. Thoughts on the failures noted for this pull: the timeout problem is probably intermittent (needs a tag?), and we can see the Hope that helps! |
Member
|
@dmarcotte: I will give your patch a run locally, and see if we need some additional tags to stabilize those failures. Thanks! |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #264. I noticed that issue had the same symptoms that #807 addressed for
each_with_index. This pull extends the #807 fix to cover thenextcase.Note also that the regression test
no_args_method.new.enum_for(:my_method).next.should == niladded here actually hangs prior to this fix (the nexter queue blocked forever waiting for a value that's not coming; now we explicitly feed it thenil), so avoiding that is a nice bonus.Between the updated arg handing and avoiding that hang, it seems like there's a chance some specs can be untagged now... I'll have a look soon.