Merged
Conversation
This removes methods with the "18", "19", or "20" suffix indicating that they are associated with those versions of Ruby. Where there existed such methods that were not previously deprecated, new deprecation was added but the methods were not removed. Any remaining callers of these methods were modified to call the non-suffixed version.
headius
force-pushed
the
remove_versioned_methods
branch
from
0bea526 to
9fa2334
Compare
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 12, 2024
These methods were not deprecated before JRuby 10, so they were left in place for one additional "major" release. This deletes them. They are very low risk of causing compile or execution problems, but this safer approach gives any remaining users a full version cycle to switch to the long-available normal versions. See jruby#8143 for the original pass that removed already- deprecated methods.
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 12, 2024
These methods were not deprecated before JRuby 10, so they were left in place for one additional "major" release. This deletes them. They are very low risk of causing compile or execution problems, but this safer approach gives any remaining users a full version cycle to switch to the long-available normal versions. See jruby#8143 for the original pass that removed already- deprecated methods.
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 13, 2024
These methods were not deprecated before JRuby 10, so they were left in place for one additional "major" release. This deletes them. They are very low risk of causing compile or execution problems, but this safer approach gives any remaining users a full version cycle to switch to the long-available normal versions. See jruby#8143 for the original pass that removed already- deprecated methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the following related to versioned methods (1.8, 1.9, etc):
Sadly, some suffixed methods were NOT yet deprecated, so they just gain new deprecations in this PR.