[ji] support re-reifying class hierarchy#8140
Merged
enebo merged 3 commits intojruby:masterfrom Apr 29, 2024
Merged
Conversation
kares
commented
Mar 5, 2024
|
|
||
| if (classLoader.hasDefinedClass(javaName)) { // class removed after being reified but parent got kept around | ||
| // while this seems like a leak the parent Java class might be GCable just hasn't been collected, yet | ||
| classLoader = new OneShotClassLoader((OneShotClassLoader) classLoader); |
Member
Author
There was a problem hiding this comment.
this extra wrapping (which under normal condition won't happen) is the fix,
not super happy about it but I wonder if there are any concerns?
Member
Author
There was a problem hiding this comment.
alternatively we could append some suffix (counter) to the class-name but having the same name seemed nice.
this also reminds me that using rubyobj. package prefix with modularization might not be "ideal".
if we would to consider having some kind of package prefix than we might want to leverage org.jruby.gen:
- "
org.jruby.gen.reified_#{ruby_class.id}.SubList"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a quick attempt to support partial removing of a reified class hierarchy... (#8141)
if this seems fishy I am okay to drop and leave this use-case as not supported