Redo java commandline calculation to work with newer Java's#8136
Merged
enebo merged 1 commit intojruby:masterfrom Mar 5, 2024
Merged
Redo java commandline calculation to work with newer Java's#8136enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
The old mechanism (which is still in this) only works for Java 8 and earlier. It walks all ClassLoaders and will cast to a unpublished type to ask for the URL for the jar the classloader represents. Java 9+ cannot do this. This fix only addresses the main Java jar by asking for a Resource for our Main class then getting a URI which we can make into a valid path to our jar. What this does not do is walk all CLs. It instead assumes all cp passed into the original Java process will work for a nested one. This may not work for 9+ but it is already broken if so. Java 8 continues to work the same way it always has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old mechanism (which is still in this) only works for Java 8 and earlier. It walks all ClassLoaders and will cast to a unpublished type to ask for the URL for the jar the classloader represents. Java 9+ cannot do this.
This fix only addresses the main Java jar by asking for a Resource for our Main class then getting a URI which we can make into a valid path to our jar.
What this does not do is walk all CLs. It instead assumes all cp passed into the original Java process will work for a nested one. This may not work for 9+ but it is already broken if so. Java 8 continues to work the same way it always has.
This is part of a fix for #8135