Rework visibility checks for Java integration#8093
Merged
headius merged 1 commit intojruby:masterfrom Feb 7, 2024
Merged
Conversation
headius
force-pushed
the
ji_visibility_tweaks
branch
from
64ef2eb to
bea8f7f
Compare
enebo
reviewed
Feb 7, 2024
core/src/main/java/org/jruby/javasupport/binding/MethodGatherer.java
Outdated
Show resolved
Hide resolved
In jruby#8061 we found that Gradle is opening several core JDK packages to support the needs of Groovy. Unfortunately this causes some normally-inaccessible methods to be accessible to JRuby's Java integration layer. In the case of HashSet, a package-private `map` method gets bound that conflicts with the Ruby version, leading to the bug reported in jruby#8061. Gradle's behavior is unsanitary, but ultimately the fix we have settled on here is to never try to set package-private methods accessible since they are truly not intended for consumption outside the package. That fixes this issue without addressing the larger problem of Gradle opening up core JDK packages. Fixes jruby#8061
headius
force-pushed
the
ji_visibility_tweaks
branch
from
bea8f7f to
de5aa75
Compare
This was referenced Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8061 we found that Gradle is opening several core JDK packages to support the needs of Groovy. Unfortunately this causes some normally-inaccessible methods to be accessible to JRuby's Java integration layer. In the case of HashSet, a package-private
mapmethod gets bound that conflicts with the Ruby version, leading to the bug reported in #8061.Gradle's behavior is unsanitary, but ultimately the fix we have settled on here is to never try to set package-private methods accessible since they are truly not intended for consumption outside the package. That fixes this issue without addressing the larger problem of Gradle opening up core JDK packages.
Fixes #8061