Merged
Conversation
headius
force-pushed
the
default_gem_nkf
branch
from
f70f8bc to
6014f18
Compare
JRuby's implementation has moved to the gem: ruby/nkf#15 The nkf library has been a default gem in CRuby since 3.0; this aligns 9.4 with that configuration. The gem will either move to bundled or out of stdlib altogether in Ruby 3.4 later this year, so I think we should take this step now.
headius
force-pushed
the
default_gem_nkf
branch
from
6014f18 to
d6f645c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JRuby's implementation has moved to the gem:
ruby/nkf#15
The nkf library has been a default gem in CRuby since 3.0; this aligns 9.4 with that configuration. The gem will either move to bundled or out of stdlib altogether in Ruby 3.4 later this year, so I think we should take this step now.