Ruby 3.3 support: add symbolize_names kwarg to MatchData#named_captures#8059
Conversation
enebo
left a comment
enebo
left a comment
There was a problem hiding this comment.
The argument processing stuff has always been a bit tedious in JRuby. The code itself is not that complicated but it feels like we could be doing this better. Keywords in particular really need a rethink for native methods.
Just change the two things and this is in.
|
@evaniainbrooks I do not see my second message about argumenterror if optional arg is not a hash. Do you see that comment? I do not seem to be able to see the actual review, |
I did not see it either, but no worries, I will add this now. |
|
Thanks! CI is pretty weird atm. I am trying to update the parser now too so we can at least pass more. |
2 participants
issue #8029
I am unsure if my usage of keywords/checkArity/optional/checkArgumentCount is correct. I couldn't find another example exactly like this in the codebase. It seems I can still call
named_captures(:bogus)without any complaints so perhaps someone can point me in the right direction.