Ruby 3.3 support: Queue#freeze now raises TypeError#8058
Merged
enebo merged 1 commit intojruby:9.5-devfrom Jan 2, 2024
Merged
Conversation
Member
|
@evaniainbrooks Can you apply this PR against the 9.5-dev branch? 9.4 is 3.1.x Ruby and 9.5 will be 3.3. Also if this is new 3.3 behavior you should add a version guard like: ruby_version_is "3.2" do
it "raises a TypeError if passed a Hash with an unknown key" do
-> { Struct.new(:animal, { name: 'chris' }) }.should raise_error(TypeError)
end
endIt also accepts a range so you can do things like |
6e90217 to
02ee063
Compare
Member
|
Looks like we have some weird problems on 9.5-dev still but it is relatively new. Thanks for the fix. I marked this item as finished in #8029. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #8029