recognize RubySymbol as assignable to String#8057
Merged
enebo merged 4 commits intojruby:masterfrom Jan 2, 2024
Merged
Conversation
Member
|
I think this looks good (this is suggestion number 2 in #8015) but I think we want @kares and @headius to consider this change to make sure classifying Symbol as j.l.String has no unexpected consequences. The single arity example show it already set Symbol as String so I am partially confused how it arrives at this behavior without your fix. There maybe is followup cleanup to remove some code which was somehow doing that? Not sure. @evaniainbrooks Not sure if this PR will get looked at until after new years so it may be a few days. |
kares
reviewed
Dec 30, 2023
core/src/main/java/org/jruby/java/dispatch/CallableSelector.java
Outdated
Show resolved
Hide resolved
kares
requested changes
Jan 1, 2024
core/src/main/java/org/jruby/java/invokers/RubyToJavaInvoker.java
Outdated
Show resolved
Hide resolved
evaniainbrooks
force-pushed
the
8015-java-method-lookup-arity
branch
from
ebecf95 to
34d7c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #8015