Various cleanups for String operations#8050
Merged
headius merged 3 commits intojruby:masterfrom Dec 22, 2023
Merged
Conversation
* Consolidate deprecated forms * Access runtime outside of loop
headius
force-pushed
the
small_tweaks
branch
2 times, most recently
from
7759bcd to
60b4d48
Compare
This led to a few other things getting split, plus a lambda form that avoids the temporary string carrier array.
This kill four arrays used to carry encoding information back to the caller. The logic is simple enough we don't need to call out. This leaves the original strTranscodeEncArgs method without any users, but it is a public API we can't eliminate without deprecation.
headius
force-pushed
the
small_tweaks
branch
from
60b4d48 to
84900f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few cleanups I ran into while poking around RubyString.