Remove implicit prologue state to methods/blocks if that state is unused#8022
Merged
enebo merged 2 commits intojruby:masterfrom Nov 24, 2023
Merged
Remove implicit prologue state to methods/blocks if that state is unused#8022enebo merged 2 commits intojruby:masterfrom
enebo merged 2 commits intojruby:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove implicit prologue state to methods/blocks if that state is unused
This is for work to speed up the startup of JRuby by reducing instrs visited in the startup interpreter. The implicit state
at the front of methods/blocks generally gets remove as dead instrs since their variables are not used. The startup
interpreter does not run the compiler passes which do this due to the significant time they take to analyze the code.
This PR is doing cheap existence checks which will remove a lot of these instrs during build time.