Expand WeakMap to allow floats and fixnums#8009
Merged
headius merged 1 commit intojruby:masterfrom Nov 29, 2023
Merged
Conversation
They will use value comparisons rather than identity comparisons to mimic CRuby's behavior for immediate values. Fixes jruby#7862
enebo
approved these changes
Nov 10, 2023
Contributor
|
Thank you for circling back to this issue. Is the right way to enhance the spec to add it the spec in this PR, or should a separate PR go to http://github.com/ruby/spec ? |
Member
Author
|
@JasonLunn either way works! Commits to the specs in the JRuby repository eventually merge back to the main spec repository and vice versa. If you want to submit a pull request to my repository for this branch, I can merge it in and we can confirm it works in CI. |
kares
reviewed
Nov 13, 2023
kares
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They will use value comparisons rather than identity comparisons to mimic CRuby's behavior for immediate values.
Fixes #7862