Merged
Conversation
… doubling 0s with # modifier
…ion as if a string
…trings encoding for %c
mhashizume
added a commit
to mhashizume/puppet
that referenced
this pull request
May 21, 2024
This commit updates the version of JRuby used in spec tests from 9.4.3.0 to 9.4.7.0, which matches what is used in the latest version of Puppet Server 8.x. (See: puppetlabs/jruby-utils@1180711.) JRuby 9.4.7.0 includes bug fixes to several issues that we have worked around in Puppet in the past: - Dir.glob not properly supporting wildcard syntax (worked around in Puppet in 663062a, resolved in JRuby in jruby/jruby@a39cd49). - format and sprintf not supporting %a and %A (worked aroundin Puppet in 334ea05, resolved in JRuby in jruby/jruby#7996). Because of these bug fixes in JRuby, this commit also removes Puppet's workarounds.
mhashizume
added a commit
to mhashizume/puppet
that referenced
this pull request
May 21, 2024
This commit updates the version of JRuby used in spec tests from 9.4.3.0 to 9.4.7.0, which matches what is used in the latest version of Puppet Server 8.x. (See: puppetlabs/jruby-utils@1180711.) JRuby 9.4.7.0 includes bug fixes to several issues that we have worked around in Puppet in the past: - Dir.glob not properly supporting wildcard syntax (worked around in Puppet in 663062a, resolved in JRuby in jruby/jruby@a39cd49). - format and sprintf not supporting %a and %A (worked around in Puppet in 334ea05, resolved in JRuby in jruby/jruby#7996). Because of these bug fixes in JRuby, this commit also removes Puppet's workarounds.
mhashizume
added a commit
to mhashizume/puppet
that referenced
this pull request
Jul 26, 2024
This commit updates the version of JRuby used in spec tests from 9.4.3.0 to 9.4.8.0, which matches what is used in the latest version of Puppet Server 8.x. (See: puppetlabs/jruby-utils@0e23173.) JRuby 9.4.8.0 includes bug fixes to several issues that we have worked around in Puppet in the past: - Dir.glob not properly supporting wildcard syntax (worked around in Puppet in 663062a, resolved in JRuby in jruby/jruby@a39cd49). - format and sprintf not supporting %a and %A (worked around in Puppet in 334ea05, resolved in JRuby in jruby/jruby#7996). Because of these bug fixes in JRuby, this commit also removes Puppet's workarounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing format specifier