[fix] infinite loop calling Java super from Ruby#7990
Merged
kares merged 1 commit intojruby:masterfrom Oct 29, 2023
Merged
Conversation
Contributor
|
Thanks for the fix! I've tested it and can confirm that this solved the problem I was having. |
Member
|
Looks good to me! |
Member
Author
|
unfortunately, this also made it to 9.3.11.0 - thus got back-ported at #7991 |
kares
added a commit
that referenced
this pull request
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduced in 9.4.4.0 while doing a variant of: bd9d40c#diff-d269af154b613900dfe27e6c544a8c6748bf52af91e74395df49c70764db1478R1841
managed to miss copy-ing the loop last step (and I was pretty confident that is a tested code path)