Remove unnecessary cast of kwargs#7984
Merged
headius merged 1 commit intojruby:masterfrom Oct 26, 2023
Merged
Conversation
The intent here was to pass in what might be kwargs if the keyword flag was set, indicating that kwargs were being passed in. This assumption seems ok so I'm not sure why it doesn't hold. In any case, the cast here is unnecessary and the IRubyObject form will return null for non-RubyHashes. The code that triggered this does deal directly with kwargs, but as a kwrest, forwarding it through a block: https://github.com/rails/rails/blob/v7.1.1/activesupport/lib/active_support/testing/time_helpers.rb#L176-L183 This could indicate JRuby failing to pass along a keyword flag when forwarding kwrest. The additional changes here are: * Fall back on non-kwargs behavior if last arg turns out not to be a hash. * Remove a redundant reset of the `callInfo` that governs keyword- passing. Fixes jruby#7982
headius
force-pushed
the
premature_kwargs_cast
branch
from
9ca8271 to
74fa59e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent here was to pass in what might be kwargs if the keyword flag was set, indicating that kwargs were being passed in. This assumption seems ok so I'm not sure why it doesn't hold. In any case, the cast here is unnecessary and the IRubyObject form will return null for non-RubyHashes.
The code that triggered this does deal directly with kwargs, but as a kwrest, forwarding it through a block:
https://github.com/rails/rails/blob/v7.1.1/activesupport/lib/active_support/testing/time_helpers.rb#L176-L183
This could indicate JRuby failing to pass along a keyword flag when forwarding kwrest.
The additional changes here are:
callInfothat governs keyword- passing.Fixes #7982