Merged
Conversation
Attempt at reducing simple instrs which can be subsumed by their neighboring instrs.
…l not advance last processed num so next side effect on same line can still lead to a linenum instr
…This will not advance last processed num so next side effect on same line can still lead to a linenum instr" This reverts commit 7300edf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to reduce extra instructions. Some line number instructions are not needed if we have the impl of those
instructions emit the line. This will end up yielding some benefits:
a. in interpreter
b. in compiler passes
-e 1 with this first commit reduces instrs execution by 1200 instrs (from 495207 -> 494016) 0.3% less. This is a tiny number but this is also only affecting one-time code.
Update: with my recent merges of implicit prologue instr removal this is down to 449335 instrs.