Convert to lower, not upper, for casecmp#7950
Merged
headius merged 1 commit intojruby:masterfrom Oct 10, 2023
Merged
Conversation
This matches the CRuby code at this point, but it's not clear to me how or why it was set up to use the upper case table many years ago. Fixes jruby#7946
Member
Author
|
It appears this changed in CRuby around 2.7 timeframe, via this commit by @jeremyevans: I don't have a good explanation for why this change fixes #7946 except that perhaps the upper case logic is conflicting with arabic characters, which have no upper case. Case folding can also be locale-specific and have other oddities. @jeremyevans Was that change just made for consistency with the other forms or was there a more specific bug fixed? |
Contributor
|
The change in ruby/ruby@082424e was made solely for consistency, not to fix a bug. |
headius
force-pushed
the
casecmp_sort_bug
branch
from
35cb07b to
ab72a2d
Compare
headius
added a commit
to headius/jruby
that referenced
this pull request
Oct 9, 2023
A number of things here seemed odd and did not match CRuby, so I completed the re-porting based on 3.3 HEAD (master). It led to a few failures across specs and MRI tests so I am moving it to a separate PR for investigation. See jruby#7950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the CRuby code at this point, but it's not clear to me how or why it was set up to use the upper case table many years ago.
Fixes #7946