Fix #7815. NullPointerException for compiled code with for loop#7948
Merged
enebo merged 2 commits intojruby:masterfrom Oct 6, 2023
Merged
Fix #7815. NullPointerException for compiled code with for loop#7948enebo merged 2 commits intojruby:masterfrom
enebo merged 2 commits intojruby:masterfrom
Conversation
AOT code encodes IR into the .class file and it was not correctly adjusting local variable operands to account for `for` loops. The code before the fix would count all possible `for` loops and not just the `for` loops between the current accessing scope and the destination scope. Added a single test which has a complicated set of variable accesses which should exercise the depth adjustment which was fixed in this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AOT code encodes IR into the .class file and it was not correctly adjusting local variable operands to account for
forloops. The code before the fix would count all possibleforloops and not just theforloops between the current accessing scope and the destination scope.Added a single test which has a complicated set of variable accesses which should exercise the depth adjustment which was fixed in this commit.