Merged
Conversation
kares
force-pushed
the
java-21
branch
2 times, most recently
from
c70b188 to
08cf307
Compare
headius
approved these changes
Oct 5, 2023
Member
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
The changes look good to me overall.
I am a bit concerned with the number of additional jobs added, however. I count something like 28 additional jobs. Some of these are quick, but several are very heavy and will add time to CI (e.g. spec:ruby:fast variations).
We can discuss this after merging (since the missing 21-ea is breaking builds right now) but the short story is that I made some suites only test on 8 and whatever is latest, assuming that passing both would mean the intermediate versions work too. We need to balance how long CI runs with how much we need to reasonably test.
Member
|
I'm going ahead with merging this since master is broken due to "21-ea" not being an installable Java anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds CI testing with Java 21 (release), also added some variations on the Java flavor used (with temurin).
The embedded (jruby-complete) test targets now also work on Java > 8 and are actively tested against later versions.
A few minor (Java) deprecations are addressed, most of the remaining ones are around SecurityManager and the related access exception being used... which are likely going to be tricky to get rid of.