Fix String#to_i with leading zero and underscores#7934
Merged
headius merged 2 commits intojruby:jruby-9.3from Sep 10, 2023
Merged
Fix String#to_i with leading zero and underscores#7934headius merged 2 commits intojruby:jruby-9.3from
headius merged 2 commits intojruby:jruby-9.3from
Conversation
We're only supposed to bail out on 2 or more consecutive underscores. Probably ported wrong since us += 0 makes 0 sense. Fixes jruby#7749
Specifically for cases with leading zeros, which falls into logic in CRuby that ignores any number of non-consecutivee underscores but bails out on two or more consecutive underscores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic here is intended to bail out when the leading digit is
0and there are two or more consecutive underscores, but it appears it was ported incorrectly (us += 0🤨) resulting in it bailing out after ANY second underscore.Fixes #7749.