Improve line numbers for generated dynscopes#7933
Merged
headius merged 1 commit intojruby:jruby-9.3from Sep 10, 2023
Merged
Conversation
This is to help debug jruby#7815 and hopefully provide more meaningful traces going forward. The non-specialized methods have line numbers from 0 up. Generated nullable getters have lines 100 + (variable offset). Generated non-nullable getters (nil for null) have lines 200 + (variable offset). Generated setters have lines 300 + (variable offset).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to help debug #7815 and hopefully provide more meaningful traces going forward.
The non-specialized methods have line numbers from 0 up. Generated nullable getters have lines 100 + (variable offset). Generated non-nullable getters (nil for null) have lines 200 + (variable offset). Generated setters have lines 300 + (variable offset).