Fix the timezone string parser so it won't choke on TZ=JST-9, etc.#793
Merged
BanzaiMan merged 1 commit intojruby:masterfrom Jun 6, 2013
knu:fix_tz_parsing
Merged
Fix the timezone string parser so it won't choke on TZ=JST-9, etc.#793BanzaiMan merged 1 commit intojruby:masterfrom knu:fix_tz_parsing
BanzaiMan merged 1 commit intojruby:masterfrom
knu:fix_tz_parsing
Conversation
The previous change in TZ_PATTERN may render the minutes part to be null, so a null check is required before passing a captured value to Integer.parseInt().
BanzaiMan
added a commit
that referenced
this pull request
Jun 6, 2013
Fix the timezone string parser so it won't choke on TZ=JST-9, etc.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous change in TZ_PATTERN may render the minutes part to be
null, so a null check is required before passing a captured value to
Integer.parseInt().