Fixes #7918. Error with single splat method with keyword arguments#7929
Merged
enebo merged 1 commit intojruby:masterfrom Sep 8, 2023
Merged
Fixes #7918. Error with single splat method with keyword arguments#7929enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
Problem was that we were seeing an empty kwarg marked from ruby2_keyword_hash and omitting it because it was a kwarg. The logic doing this was for a failing test in MRI test suite that was passing that empty kwarg using a splat. The fix was to only pass this along if it is a non-splat caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem was that we were seeing an empty kwarg marked from ruby2_keyword_hash and omitting it because it was a kwarg. The logic doing this was for a failing test in MRI test suite that was passing that empty kwarg using a splat. The fix was to only pass this along if it is a non-splat caller.