Make bound method management threadsafe#7917
Merged
headius merged 1 commit intojruby:jruby-9.3from Sep 4, 2023
Merged
Conversation
Member
|
Could you actually just rebase this on 9.3? We are still merging 9.3 changes forward to 9.4 and this should be fixed in both. It looks good to me! Thanks! |
Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
chadlwilson
force-pushed
the
bound-methods-thread-safety
branch
from
6e674a1 to
323aa6e
Compare
Contributor
Author
|
@headius oh okay, done now. I thought you used a backport approach rather than merge forward. My bad. |
Member
|
Looks good! |
Contributor
Author
|
Do you want me to open a cherry-pick PR to master, or do you have a regular process to do this? |
Member
|
Nope, already merged! We find it easier to merge forward because most changes happen on master, and everything fixed in a maintenance branch should also be applied to master. |
Member
|
@enebo Another one we should get 9.3.11 out for soon... |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not quite sure the appropriate sizing of the Maps here, but tried to follow existing conventions elsewhere and be conscious of the additional overhead of
ConcurrentHashMaps for the nested Maps. But this may also be premature optimization in some areas, so will take maintainer guidance.RubyModuleI also can't find an appropriate place to write particular tests here, so any pointers useful.
Needs to be ported forward to 9.4/master if suitable.