RubyArray: Fix intersect? for small arrays#7905
Merged
enebo merged 1 commit intojruby:masterfrom Aug 28, 2023
Merged
Conversation
Contributor
|
nice! There's already a unit test and it's passing with your change. Could you remove the tag? https://github.com/jruby/jruby/blob/master/spec/tags/ruby/core/array/intersect_tags.txt#L1 |
Contributor
Author
|
Amended the commit, and hopefully now all tests pass. Not very familiar with the code base, was just looking for a bug to solve last night :) @ahorek should I remove the tag file entirely (like I did) or just leave it empty? Looked around a bit in the source code didn't see any empty ones. |
Contributor
|
if there's only a single tag, you can remove the whole file. Thanks |
Member
|
@skmp Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the mainline ruby code,
intersect?is supposed to test by Eql, not by Equal.For the small-array optimisation of this,
includes_pwas used, instead ofincludesByEql, which gave wrong results.Issue: #7852
, though this should really also have a unit test somewhere.