Move frozen string debug fields into subclass#7903
Merged
headius merged 1 commit intojruby:masterfrom Aug 28, 2023
Merged
Conversation
headius
force-pushed
the
lighter_debug_frozen_strings
branch
from
aeb68f6 to
306a16c
Compare
This avoids adding anything to the ivar table and short-circuits the frozen check. We may want to consider doing this for non-debug frozen literal strings as well. Note: This removes the debug check from "DStr" logic in BuildCompoundStringInstr because I could find no case where CRuby attaches debug info to a dynamically-constructed frozen string, and removing it did not appear to affect any tests.
headius
force-pushed
the
lighter_debug_frozen_strings
branch
from
306a16c to
11418c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids adding anything to the ivar table and short-circuits the frozen check. We may want to consider doing this for non-debug frozen literal strings as well.