Update test_bigdecimal.rb and fix a few failures#7897
Merged
enebo merged 7 commits intojruby:masterfrom Aug 20, 2023
Merged
Conversation
The following tests will pass. * test_round_half_invalid_option in test/mri/bigdecimal/test_bigdecimal.rb * spec/ruby/library/bigdecimal/round_spec.rb
BigDecimal#remainder with Infinity should return self. The following test will pass * test_reminder_infinity_gh_187 in test/mri/bigdecimal/test_bigdecimal.rb
Member
|
@k77ch7 I think that is ok but it is always hard to know what people actually hit in these libraries. |
Contributor
Author
|
@enebo I feel the same. By the way, do you have any plans to gemify JRuby's BigDecimal implementation? |
Member
|
@k77ch7 no current plans but it should probably eventually be that way to match up with the other gems C Ruby also gemifies. |
Contributor
Author
|
@enebo Thanks again. |
Member
|
@k77ch7 I just going to 👍 this but you are the one who needs thanking. Bigdecimal would not be where it is today without your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates test_bigdecimal.rb from bigdecimal v3.1.4.
And this PR fixes a few failures.
I believe that this implementation enhances JRuby's compatibility. However, please note that an exclusion tag has been added.